Re: moving egg_screen_* into libgnomeui



Mark McLoughlin <mark skynet ie> writes:
> > Isn't the whole gnome-exec family deprecated? (If not, shouldn't it
> > be?) Should we really be adding extra variants?
> >
> > My feeling is that we should consider gdk_spawn_* here.
> 
> 	Agreed. I'll start a GEP on that ...

I think it's cheesy enough that a GEP isn't really required...

> > Do the with_env functions replace or supplement the environment? If
> > they replace it's probably broken to do that, if they supplement the
> > function names are misleading as you would expect execve() behavior.
> 
> 	Interestingly gspawn allows both behaviours - with the execve
> behaviour taking precendence over the ChildSetupFunc. Why is it broken
> to use execve in this case ?

You probably want to keep env variables such as SESSION_MANAGER,
e.g. you'd want the help browser to pick that up, right?

> 	So, I'd actually be more concerned about getting the gnome-url
> and gnome-help functions in before 2.2 than the gnome-exec ones. The
> gnome-exec ones are just wrappers functions so we're not copying to
> much code around the place using libegg - but the gnome-url and
> gnome-help ones can't be wrapped so libegg actually contains a copy of
> their implementations.

I agree.

Havoc





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]