Re: PATCH: fix gnome-druid-edge

[Jonathan Blandford <jrb redhat com>]

Alan Cox <alan redhat com> writes:

> It appears the edge druid has been suffering bitrot so that when I ported
> gnome-lokkit to gnome-2.0 it broke.
> 
> The patch fixes
> 
> 1.	Remove x_set/y_set canvas properties that no longer exist
> 2.	Remove the use of "fontset" canvas properties that no longer exist
> 3.	Use pango markup for the title text  (as druid-standard does)
> 4.	Adjust the various constants to reflect gnome-druid-standard changes
> 	Now when you mix edge and standard druid pages they match up
> 5.	Adjust the icon layout to match the standard druid
> 6.	Fix an off by one in the left hand image positioning
> 7.	Fix the image positions that were broken by past canvas changes
> 8.	Stop text wrapping into the left hand logo area
> 
> This fixes all but one remaining text layout issue. That is caused by
> the fact "text_width" is broken in the canvas and needs to be fixed there
> not in the druid.

The patch looks pretty good.  Please feel free to commit.

> Both druids (standard and edge) still fail when the window mangler reduces
> them below the gtk hinted minimum size [try viewing one on an iPAQ] but
> thats a seperate issue.

Yeah.  I think that you might just want to write your own DruidPage in that
case (especially as it's so much easier now).

> PS: libgnomeui claims to be GPL not LGPL. I though that was not the
> plan - did someone use the wrong COPYING file in the toplevel dir 

It's definitely LGPL.  I thought Anders had fixed that, though.

-Jonathan