Re: gnome-window-icon.[ch], again



On Mon, 2001-09-10 at 22:57, jacob berkman wrote:
> hello,
> 
> here is my proposed gnome-window-icon api.  the differences between it
> and the gnome 1 version are that the _from_imlib() versions are gone,
> and there are _from_file_list() versions added, and _set_from_default()
> does nothing (since gtk 2.0 does this for us).
> 
> there are no _from_pixbuf() since there is gtk api to do this.
> 
> this is basically a wrapper around the gtk window functions, except
> these take string arguments and load the pixbufs for you (which is much
> simpler imho).
> 
> if you want to ask about api freezes, this should be added now because
> it was in gnome 1.2+, but it was not in gnome-libs when the original
> gnome 2.0 branches were made, so hasn't been in libgnomeui 2 yet.
> 
> 

Yes, the patch looks fine to me. Before committing it, can you remove
the note in the header file about the functions being added with the
1.2.0 release since that's not necessary anymore.

Also, could you add an include of the header file to libgnomeui.h?

//andersca
andersca gnu org





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]