Small libgnomeui changes



Hi,

While reviewing libgnomeui for any potential 64-bit problems I made a few small 
changes.  If libgnomeui isn't officially dead yet (just looking at Martin's 
mail) I was wondering if someone would care to comment/commit or does anyone 
mind if I commit myself?

Let me know if there are any comments.

Thanks,

Mark


----------------------------------
Mark Murnane
Desktop, Applications & Middleware
Sun Microsystems Ireland
----------------------------------
Index: libgnomeui/ChangeLog
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/ChangeLog,v
retrieving revision 1.1596
diff -u -r1.1596 ChangeLog
--- libgnomeui/ChangeLog	2001/06/19 05:38:25	1.1596
+++ libgnomeui/ChangeLog	2001/06/21 14:51:18
@@ -1,3 +1,22 @@
+2001-06-21  Mark Murnane  <Mark Murnane Sun com>
+
+	* Changes made during 64-bit cleaning.
+
+	* gnome-dateedit.c (day_selected): Modified type of day, month and year
+	to match signature of gtk_calendar_get_date.
+
+	* gnome-icon-text.c (gnome_icon_layout_text):  Changed w_len and sublen
+ 	to a gsize.
+
+	* gnome-less.c (gnome_less_write_fd): Changes len and bytes_written to
+	a gsize.
+
+	* gnome-remote_bootstrap.c (main): Changed setenv to putenv.  Solaris
+	does not have a setenv libc function.
+
+	* gnome-unit-spinner.c: Added include directive for string.h.  Required
+	to ensure proper forward declaration of strcmp().
+
 2001-06-19  Cody Russell  <bratsche gnome org>
 
 	* gnome-animator.[ch]: Removed.
Index: libgnomeui/gnome-dateedit.c
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/gnome-dateedit.c,v
retrieving revision 1.48
diff -u -r1.48 gnome-dateedit.c
--- libgnomeui/gnome-dateedit.c	2001/06/14 15:55:36	1.48
+++ libgnomeui/gnome-dateedit.c	2001/06/21 14:51:18
@@ -116,7 +116,7 @@
 day_selected (GtkCalendar *calendar, GnomeDateEdit *gde)
 {
 	char buffer [40];
-	gint year, month, day;
+	guint year, month, day;
 
 	gtk_calendar_get_date (calendar, &year, &month, &day);
 
Index: libgnomeui/gnome-icon-text.c
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/gnome-icon-text.c,v
retrieving revision 1.7
diff -u -r1.7 gnome-icon-text.c
--- libgnomeui/gnome-icon-text.c	2000/02/21 17:31:54	1.7
+++ libgnomeui/gnome-icon-text.c	2001/06/21 14:51:18
@@ -92,7 +92,8 @@
 	GdkWChar *row_end;
 	GdkWChar *s, *word_start, *word_end, *old_word_end;
 	GdkWChar *sub_text;
-	int i, w_len, w;
+	int i, w;
+	gsize w_len;
 	GdkWChar *text_wc, *text_iter, *separators_wc;
 	int text_len_wc, separators_len_wc;
 
@@ -218,7 +219,7 @@
 		} else {
 			/* Create subrow and append it to the list */
 
-			int sub_len;
+			gsize sub_len;
 			sub_len = word_end - text_iter;
 
 			sub_text = g_new (GdkWChar, sub_len + 1);
Index: libgnomeui/gnome-less.c
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/gnome-less.c,v
retrieving revision 1.27
diff -u -r1.27 gnome-less.c
--- libgnomeui/gnome-less.c	2001/04/23 23:55:18	1.27
+++ libgnomeui/gnome-less.c	2001/06/21 14:51:19
@@ -521,8 +521,8 @@
 gnome_less_write_fd(GnomeLess * gl, int fd)
 {
 	gchar * contents;
-	gint len;
-	gint bytes_written;
+	gsize len;
+	gsize bytes_written;
 	GtkTextIter start, end;
 
 
Index: libgnomeui/gnome-remote-bootstrap.c
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/gnome-remote-bootstrap.c,v
retrieving revision 1.7
diff -u -r1.7 gnome-remote-bootstrap.c
--- libgnomeui/gnome-remote-bootstrap.c	2001/06/13 18:51:36	1.7
+++ libgnomeui/gnome-remote-bootstrap.c	2001/06/21 14:51:19
@@ -61,9 +61,9 @@
       return 1;
     }
 
-  setenv("DISPLAY", display, TRUE);
+  putenv(g_strconcat("DISPLAY", display, NULL));
   if(strcmp(languages, "C"))
-    setenv("LANG", languages, TRUE);
+    putenv(g_strconcat("LANG", languages));
 
   memset(&myprog, 0, sizeof(myprog));
   myprog.pipe_fd = -1;
Index: libgnomeui/gnome-unit-spinner.c
===================================================================
RCS file: /cvs/gnome/libgnomeui/libgnomeui/gnome-unit-spinner.c,v
retrieving revision 1.6
diff -u -r1.6 gnome-unit-spinner.c
--- libgnomeui/gnome-unit-spinner.c	2000/12/01 22:42:51	1.6
+++ libgnomeui/gnome-unit-spinner.c	2001/06/21 14:51:19
@@ -21,6 +21,7 @@
 */
 
 #include <ctype.h>
+#include <string.h>
 
 #include "gnome-unit-spinner.h"
 #include "gdk/gdkkeysyms.h"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]