Re: Many PO files with wrong permissions



On àà., 2005-10-06 at 01:02 +0200, Christian Rose wrote:
> 2005/9/28, Christian Rose <menthos gnome org>:
> > > I know we've got an archaic version of gettext running pre-commit checks
> > > on container, but I wasn't aware it was failing good translations. What
> > > are the errors?
> > >
> > > Or are you talking about the tmpfile location failure from the
> > > po-commits-list script. I'm going to fix that right now!! :)
> >
> > Yes, I'm talking about that error. It has proven to be rather confusing
> > for many translators (i.e. "Why did I get an error, when my translation
> > is correct?" or "Did my translation get accepted or not?"). That type of
> > confusion.
> >
> > If a "po file is non-executable" check can be added to the pre-commit
> > checks, and if that check is silent if there is no error, then I'm all
> > for it. This includes running a script like the one Jens provided for
> > fixing old translations in CVS. Unfortunately, I will not have time to
> > do it myself though.
> 
> Hmm, I noticed something was missing lately, but could not figure out
> what it was. Then I realized that the tempfile error was gone, and
> that's what I've been missing... :)
> Thanks a lot Ross!
> 
> Any chance you could add a "make sure po files are not executable"
> check as well to the po file precommit checks?
> 
> Christian


The pre-commit hook I have prepared for our subversion migration
contains an executable check, as well as the standard 'msgfmt' check.
I've just finished testing it locally.

In case anyone else finds it useful for their (non-GNOME) Subversion
repos, I've put a copy up here too:

http://www.gnome.org/~rossg/pre-commit-check-po.sh

--
Ross




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]