Re: [evolution-patches] 17338 - Translator Credits in About Box

[Not Zed <notzed ximian com>]

On Wed, 2004-09-08 at 13:08 -0400, JP Rosevear wrote:
> On Tue, 2004-09-07 at 15:37 -0400, Dan Winship wrote:
> > On Tue, 2004-09-07 at 15:01 -0400, JP Rosevear wrote:
> > > Also, the utf8 comment seems odd, could this be a pre 1.4 hold over? I
> > > didn't escape some new people and that seemed to work fine.
> > 
> > \x is greedy, so if you say "Garc\xC3\xADa", it's parsed as "Garc\xC3"
> > plus a "warning: hex escape sequence out of range". It's only a problem
> > for \x escapes followed by a valid hex digit as the next character
> > though, which is probably why you didn't have any problems with it.
> > 
> > > +       "Danilo Šegan",
> > 
> > You should either use \x escapes there, or use actual UTF-8 chars
> > consistently through the whole array.
>
> Attached patch breaks string freeze, in the spot to grab translator
> credits, I was told in #gnome-i18n this was the way to do it.

You've broken the sorting.  It was sorted on surname.

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer

Attachment: zed-48.small.jpg
Description: Binary data