Re: String freeze breakage in gtkhtml

[Radek Doulik <rodo ximian com>]

Hi Danilo,

that change went in by mistake and is reverted now. Thank for letting me know about it.

Cheers
Radek

On Thu, 2004-10-21 at 17:16 +0200, Danilo Šegan wrote:
> Hi Radek,
>
> There's been unannounced and unapproved string addition in gtkhtml on
> gnome-2-8 branch:
>
> #: components/html-editor/spell.c:110
> msgid ""
> "Unable to add word to dictionary,\n"
> "language settings are broken.\n"
>
>
> Gnome 2.8 is still string-frozen, so any string changes would need to
> go through the procedure as outlined at:
>
>   http://developer.gnome.org/dotplan/tasks.html#ApprovingFreezeBreaks
>
> This is your changelog entry (though, commit happened yester):
>
> 2004-10-15  Radek Doulik  <rodo ximian com>
>
>         * spell.c (spell_add_to_personal_no_language): new helper method
>         to report broken language settings
>         (spell_add_to_personal): call spell_add_to_personal_no_language if
>         language is null
>         (add_cb): ditto
>
> And here's a change:
>   It would be nice if you explained why is this change desireable on
> frozen gnome-2-8 branch, or if you reverted it (provided you don't
> think it's a must-have).
>
> Cheers,
> Danilo