Re: [patch] fstab-sync mount point names
- From: Kjartan Maraas <kmaraas broadpark no>
- To: Alexander Larsson <alexl redhat com>
- Cc: gnome-i18n gnome org, "gnome-vfs-list gnome org" <gnome-vfs-list gnome org>, David Zeuthen <david fubar dk>, utopia-list gnome org, "release-team gnome org" <release-team gnome org>
- Subject: Re: [patch] fstab-sync mount point names
- Date: Tue, 31 Aug 2004 11:39:34 +0200
tir, 31,.08.2004 kl. 09.10 +0200, skrev Alexander Larsson:
> On Mon, 2004-08-30 at 19:24, David Zeuthen wrote:
> > On Mon, 2004-08-30 at 19:16 +0200, David Zeuthen wrote:
> > > Hi Alex,
> > >
> > > This simple patch adds some more heuristics to recognize the mount point
> > > names generated by fstab-sync. Also, this patch uses the some of new and
> > > cool icons Jimmac put in gnome-icon-themes. You can find a screenshot
> > > right here
> > >
> >
> > Attached is an improved version that fixes one leak compared to the
> > inital patch. Doh!
>
> The patch looks fine to me, but it adds strings, so it can't go into 2.8
> as is, even with release-team approval. We could probably get the
> non-stringchanging parts into cvs, as they are pretty simple to review
> and don't affect stability.
>
> release-team, is this patch ok for gnome 2.8? All it does is recognize
> some mountpoint names that HAL creates and give them more descriptive
> icons. (The icons are alreay in gnome-icon-theme.)
>
> For fedora, i guess we'll have the string-additions as an extra patch in
> the rpm.
>
If the strings are visible adding the patch to the RPM will create
problems for translations in FC3. I'm not sure what will annoy the
translators most, having a few more strings to translate in HAL or
having them untranslated in every installed FC3 system? :-)
I would be ok with adding them upstream, but that's not my call to make
I guess.
Cheers
Kjartan
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Alexander Larsson Red Hat, Inc
> alexl redhat com alla lysator liu se
> He's an underprivileged day-dreaming dwarf living undercover at Ringling Bros.
> Circus. She's a radical green-skinned fairy princess from a family of eight
> older brothers. They fight crime!
>
> _______________________________________________
> release-team mailing list
> release-team gnome org
> http://mail.gnome.org/mailman/listinfo/release-team
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]