Desktop could be stuck b'cause of Trash Dialog.

Hi All,

This is regarding bug,

Invoke the trash dialog through the keyboard, this causes the whole
desktop to be stuck unless the dialog is dismissed. This is due to
"Empty Trash" button and "Edit" menu having the same mnemonics.

The fix should be ideally in gtk+, i.e. resolving the conflict. But
based on comments from Owen w.r.t code and Calum w.r.t to usability,  I
would like to request the change in the mnemonic for "Empty Trash"

Would like to see this bug fixed for the 2.2 release. :)  Attaching the
patch as well.

Please let me know your views.

Index: nautilus/ChangeLog
RCS file: /export/cvs/gnome-2.0/nautilus/ChangeLog,v
retrieving revision 1.5638
diff -p -u -5 -r1.5638 ChangeLog
--- nautilus/ChangeLog	2002/12/31 22:18:01	1.5638
+++ nautilus/ChangeLog	2003/01/04 08:20:51
@@ -1,5 +1,13 @@
+2003-01-04  Arvind Samptur <>
+	* src/nautilus-information-panel.c
+	(nautilus_information_panel_update_buttons): changing the
+	mnemonic of "Empty Trash" button. Resolves the conflict
+	between "Edit" menu option and "Empty Trash" button, which
+	caused the desktop to be badly stuck.
+	Please see #101690, for Owen's comments as well.
 2002-12-31  Dave Camp  <>
 	* src/ Applied UI review 
 	suggestions.  Patch from Luca Ferretti <>
Index: nautilus/src/nautilus-information-panel.c
RCS file: /export/cvs/gnome-2.0/nautilus/src/nautilus-information-panel.c,v
retrieving revision 1.219
diff -p -u -5 -r1.219 nautilus-information-panel.c
--- nautilus/src/nautilus-information-panel.c	2002/10/31 22:38:46	1.219
+++ nautilus/src/nautilus-information-panel.c	2003/01/04 08:20:51
@@ -1013,11 +1013,11 @@ nautilus_information_panel_update_button
 	/* here is a hack to provide an "empty trash" button when displaying the trash.  Eventually, we
 	 * need a framework to allow protocols to add commands buttons */
 	if (eel_istr_has_prefix (information_panel->details->uri, "trash:")) {
 		/* FIXME: We don't use spaces to pad labels! */
-		temp_button = gtk_button_new_with_mnemonic (_("_Empty Trash"));
+		temp_button = gtk_button_new_with_mnemonic (_("Empty _Trash"));
 		gtk_box_pack_start (GTK_BOX (information_panel->details->button_box), 
 					temp_button, FALSE, FALSE, 0);
 		gtk_widget_set_sensitive (temp_button, !nautilus_trash_monitor_is_empty ());
 		gtk_widget_show (temp_button);

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]