Re: gok string freeze breakage

[David Bolter <david bolter utoronto ca>]

Mark,

Thanks for this, my comments are below.

Mark McLoughlin wrote:
> Hi David,
> 
> On Mon, 2003-08-11 at 20:30, David Bolter wrote:
> 
>>I think it is important to make changes to gok's about box that will 
>>break the string freeze.  Can I go ahead and commit, or would you like a 
>>  diff?
>>
>>It is a UI change.
>>
>>Patch is here:
>>http://bugzilla.gnome.org/show_bug.cgi?id=119665
> 
> 
> 	Some comments:
> 
> 	1) I'm not particularly happy with such a large UI addition, this late
> in the release cycle. I do appreciate that it would be a shame not to
> credit the contributors in the UI for this first release.
> 
> 	2) I don't like the idea of creating a special about dialog for gok.
> I'd much prefer to see gok, as part of the desktop, using the gnome
> infrastructure ... i.e. GnomeAbout. I know GnomeAbout doesn't fit your
> needs exactly right now, but you could take a two pronged approach of
> using GnomeAbout as best you can - e.g. by just crediting everyone (in
> alphabetical order) who contributed in "Written By" like other GNOME
> about dialogs (e.g. the panel) - while at the same time driving changes
> in GnomeAbout so that it will fit your needs in a future release.

I have added comments to the running bug, perhaps others also could help 
drive it for 2.6.x?

http://bugzilla.gnome.org/show_bug.cgi?id=80468

> 
> 	3) I don't understand why, in the patch, you are constructing the
> dialogs by hand, while you also have a glade file for the dialogs.
> What's going on here ?

Sorry about that, I left the commented out "by hand" stuff in the source 
file when I did the diff.  That is probably what you are seeing.

> 
> 	4) The points that Christian made are all valid IMHO and those changes
> should be made if the patch is to go in.

I see Christian's points in the bug report (which I think you are 
referring to). I agree with these, although I think I will hold off this 
big change based on your concerns.

> 
> 	5) How does this relate to the string freeze breakage reported by
> Christian. That also seemed to be related to the about dialog. What's
> going on here ?

Unfortunately the same subject line was used by me causing some 
confusion no doubt.  The original breakage was a simple error dialog 
related to bug 118684.  AFAIK, that was my first and only naughty breakage.

> 
> 	6) Its pretty much standard in GNOME to use unified diffs (diff -u) and
> most people are much more comfortable reading them.
>

Okay, thanks!

I don't want to cause any problems so I think I will follow your advice 
in #2 for now, and list people in the "Written By" section.  Except this 
is also a UI change.  Do I have permission?

cheers,

David