Re: gnome-media string freeze breakage

[Christian Rose <menthos menthos com>]

lör 2002-08-03 klockan 14.51 skrev iain:
> > > Hi!
> > > ----
> > > 2002-08-01  Iain <iain@prettypeople.org>
> > > 
> > > 	* POTFILES.in: Added the schemas files...
> > > ----
> > > 
> > > This addition produced error in intltool update (i've fixed it) and some
> > > warnings. Also string freeze is broken. 
> > 
> > Argh! I thought this type of stuff was supposed to wait for 2.2!
> 
> The schemas stuff didn't break the string freeze as there's nothing in
> the schemas file to be translated, the intltool error was me being a
> dumbass but it's now fixed, and the string freeze breakage was me not
> knowing it was a string freeze, and me being stupid, and me going
> through the buglist and committing all the patches that have been lying
> there for 2 months. Apologies to all concerned, I'll be much more
> careful in future.

Yup, I noticed now, these are the changes breaking freeze:

----------------------------
revision 1.55
date: 2002/08/02 23:47:28;  author: iain;  state: Exp;  lines: +2 -3
Make the volume slider work the correct way.
----------------------------
--- gnome-cd/gnome-cd.c 22 Jun 2002 13:11:47 -0000      1.54
+++ gnome-cd/gnome-cd.c 2 Aug 2002 23:47:28 -0000       1.55
[...]
        gtk_tooltips_set_tip (gcd->tooltips, GTK_WIDGET (gcd->slider),
-                             _("Volume Control"), NULL);
+                             _("Volume control"), NULL);
 
        gtk_box_pack_start (GTK_BOX (gcd->vbox), top_hbox, TRUE, TRUE, 0);
 
----------------------------
revision 1.5
date: 2002/08/02 23:36:14;  author: iain;  state: Exp;  lines: +1 -1
Fix some capitalisation problems
----------------------------
--- gnome-cd/gnome-cd.desktop.in        9 Jul 2002 00:22:30 -0000       1.4
+++ gnome-cd/gnome-cd.desktop.in        2 Aug 2002 23:36:14 -0000       1.5
@@ -1,5 +1,5 @@
 [Desktop Entry]
-_Name=CD Player
+_Name=CD player
 _Comment=Play audio CDs
 Exec=gnome-cd
 Icon=gnome-cd.png

...and two other similar changes to desktop files. Also, I'm not sure
about the last change above, I suspect it breaks HIG capitalization
recommendations for menu items? It also breaks consistency with the
other menu items since it doesn't use the same capitalization.

Also,the file names in POTFILES.in still weren't correct, I hope I have
managed to fix that now :)


Christian