regressions in run dialog

[Gediminas Paulauskas <menesis delfi lt>]

Tr, 2002-05-15 03:28, Gnome CVS User rašė:
> 
> CVSROOT:	/cvs/gnome
> Module name:	gnome-panel
> Changes by:	jirka	02/05/14 21:28:05
> 
> Modified files:
> 	gnome-panel    : ChangeLog Makefile.am gnome-run.c menu-fentry.c 
> 	                 menu-fentry.h menu.c 
> 	                 panel-per-panel-config.schemas 
> 	                 quick-desktop-reader.c quick-desktop-reader.h 
> Added files:
> 	gnome-panel    : disclosure-widget.c disclosure-widget.h 
> 
> Log message:
> Tue May 14 18:37:24 2002  George Lebl <jirka 5z com>
> 
> * gnome-run.c, disclosure-widget.[ch], Makefile.am,
> quick-desktop-item.[ch]:  Apply and massage Frank Worsley
> <fworsley shaw ca>'s patch to use Iain's cddb disclosure
> widget and launch files and lookup icons and just do bunches
> of cool stuff

Yeah, the dialog now looks cool, especially the icon automatically
appearing.

However, it has regressions in keyboard navigation:

1) "Append file..." button does not have mnemonics. Easy to fix

2) "Known applications" widget does not have mnemonics. This is worse,
because the disclosure widget does not support mnemonics at the moment.

3) Also, the disclosure widget replaced two things: a button and a
label. So even if "_Known applications" had mnemonics (and pressing it
opened/closed the list), there is no way to focus the programs list
(except hitting the tab).

The related bug is http://bugzilla.gnome.org/show_bug.cgi?id=70512
 
> * gnome-run.c, menu-fentry.[ch]: add an exec field to the FileRec
> so that we can add an EXEC column.  Also add an icon column so
> that for the icon lookup we do no loading of entries.  Should
> reduce overhead of icon lookup by quite a bit.
> 
> * gnome-run.c, menu.c: Modify error dialogs to all use the
> bold/details style that is used elsewhere in the panel

I am not the person who will argue that this change (strings were
changed in quite a few dialogs) happened after the UI/string freeze,
but... it did.
 
> URL : http://cvs.gnome.org/bonsai/cvsquery.cgi?module=gnome-panel&branch=HEAD&branchtype=match&dir=gnome-panel&file=&filetype=match&who=jirka&whotype=match&sortby=Date&hours=&date=explicit&mindate=05%2F14%2F02+21%3A27&maxdate=05%2F14%2F02+21%3A29&cvsroot=%2Fcvs%2Fgnome
> 
-- 
Gediminas