Re: GNOME CVS: gnome-panel cneumair

[Kevin Vandersloot <kfv101 psu edu>]

Hmm, It looks like more unapproved commits to gnome-applets also. Chris
- It would also be nice of you to revert your commit to gweather applet
changing the ordering of the pref tabs. This was unaproved and seems
useless to me as it requires doc images to be updated needlessly. The
part about the tab mnemonics is okay to change. 

Regards,
Kevin

On Sat, 2002-12-07 at 16:25, Mark McLoughlin wrote:
> Hey,
> 	I was also aware of a previous unapproved commit
> by you but assumed it was a minor issue. I just checked.
> 
> @@ -287,7 +287,7 @@ about_cb (GtkWidget *menuitem, gpointer 
>  	}
>  	
>  	about = gnome_about_new ( _("The GNOME Panel"), VERSION,
> -			_("(C) 1997-2002 the Free Software Foundation"),
> +			_("(C) 1997 Free Software Foundation, Inc."),
>  			comment->str,
>  			(const char **)authors,
>  			(const char **)documenters,
> 
> 	Please explain why on earth you are going around
> changing copyright strings without approval ?
> 
> Thanks,
> Mark.
> 
> 
> On Sun, 2002-12-08 at 10:18, Mark McLoughlin wrote:
> > Hi Christian,
> > 	Committing unapproved patches to a module without
> > even letting the maintainer know is unacceptable. I've
> > reverted the commit.
> > 
> > 	You may have felt this was a cosmetic change, but
> > what you failed to realise is that this breaks compatibility
> > with existing panel configurations. This is why we have a
> > policy of requiring patches to be reviewed.
> > 
> > Good Luck,
> > Mark.
> > 
> > On Sat, 2002-12-07 at 08:09, Gnome CVS User wrote:
> > > CVSROOT:	/cvs/gnome
> > > Module name:	gnome-panel
> > > Changes by:	cneumair	02/12/06 14:09:48
> > > 
> > > Modified files:
> > > 	gnome-panel    : ChangeLog menu.c panel-config-global.c 
> > > 	                 panel-config-global.h 
> > > 	                 panel-global-config.schemas.in panel.c 
> > > 
> > > Log message:
> > > tooltips_enabled => enable_tooltips
> > > 
> > > URL : http://cvs.gnome.org/bonsai/cvsquery.cgi?module=gnome-panel&branch=&branchtype=match&dir=gnome-panel&file=&filetype=match&who=cneumair&whotype=match&sortby=Date&hours=&date=explicit&mindate=2002-12-06%2014:08&maxdate=2002-12-06%2014:10&cvsroot=/cvs/gnome
> > > 
> > > _______________________________________________
> > > cvs-commits-list mailing list
> > > cvs-commits-list gnome org
> > > http://mail.gnome.org/mailman/listinfo/cvs-commits-list
> 
> _______________________________________________
> gnome-hackers mailing list
> gnome-hackers gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-hackers