Re: a patch for tasklist segfaulting...

[Federico Mena Quintero <federico ximian com>]

Jaka Mocnik <jaka gnu org> writes:

> As tasklist applet has been occassionally segfaulting, because
> GwmhTask's name member was NULL, I've commited this patch to gnome-core
> HEAD. I suppose this is not the nicest solution, as I haven't really
> tracked down the why GwmhTask's name member is NULL, but it prevents
> segmentation faults which take down the whole panel as the applet is a
> library...

It is rather scary that these patches are going through without any
review.

	"It crashes because something is NULL"

	"Well, just return if it is NULL"

Without ever checking if that is a valid condition and indeed the
simple fix was correct, or if it is just a handwaving hack.

  Federico