Re: Patch for gnome-icon-entry.c for 1.4.x

[George <jirka 5z com>]

On Mon, May 06, 2002 at 05:33:37PM +0100, Bastien Nocera wrote:
> > -#include <unistd.h>
> >  #include <string.h>
> 
> The unistd.h include should be needed indeed.

yes

> > @@ -84,7 +83,7 @@
> >  static void
> >  gnome_icon_entry_class_init (GnomeIconEntryClass *class)
> >  {
> > -	parent_class = gtk_type_class (gtk_hbox_get_type ());
> > +	parent_class = gtk_type_class (gtk_vbox_get_type ());
> >  }
> 
> Is the toplevel widget of the GnomeIconEntry a vbox ? If so, yes, the
> parent class should be the one of the vbox.

Oh yes please! It is a vbox!

> 
> >  				/*get around the g_free/free issue*/
> >  				gchar *cwd = g_get_current_dir ();
> >  				p = g_strdup(cwd);
> > -				free(cwd);
> > +				g_free(cwd);
> 
> Why not simply p = g_get_current_dir () and remove all use of cwd ?

yeah, just do p = g_get_current_dir ().  The above was a conglomeration of
random hacks.

George

-- 
George <jirka 5z com>
   A good memory is needed after one has lied.
                       -- Pierre Corneille
_______________________________________________
gnome-hackers mailing list
gnome-hackers gnome org
http://mail.gnome.org/mailman/listinfo/gnome-hackers