Re: GNOME CVS: gnome-panel cneumair

[Christian Neumair <chris gnome-de org>]

Am Sam, 2002-12-07 um 22.25 schrieb Mark McLoughlin:
> Hey,
> 	I was also aware of a previous unapproved commit
> by you but assumed it was a minor issue. I just checked.
> 
> @@ -287,7 +287,7 @@ about_cb (GtkWidget *menuitem, gpointer 
>  	}
>  	
>  	about = gnome_about_new ( _("The GNOME Panel"), VERSION,
> -			_("(C) 1997-2002 the Free Software Foundation"),
> +			_("(C) 1997 Free Software Foundation, Inc."),
>  			comment->str,
>  			(const char **)authors,
>  			(const char **)documenters,
> 
> 	Please explain why on earth you are going around
> changing copyright strings without approval ?

Sorry for not informing you.
We had a discussion on gnome-i18n:
http://lists.gnome.org/archives/gnome-i18n/2002-September/msg00097.html
http://lists.gnome.org/archives/gnome-i18n/2002-November/msg00230.html
http://lists.gnome.org/archives/gnome-i18n/2002-December/msg00001.html
After reading *many* articles on copyright laws I finally decided to use
the variant described in 2002-December/msg00001.
I'm sorry for having omitted all maintainers. I've learned my lesson and
it won't happen again (unfortunately I commited similar fixes to other
modules). I'm very unexperienced and was obviously to motivated.
Feel free to revert the change.

regs,
 Chris


> On Sun, 2002-12-08 at 10:18, Mark McLoughlin wrote:
> > Hi Christian,
> > 	Committing unapproved patches to a module without
> > even letting the maintainer know is unacceptable. I've
> > reverted the commit.
> > 
> > 	You may have felt this was a cosmetic change, but
> > what you failed to realise is that this breaks compatibility
> > with existing panel configurations. This is why we have a
> > policy of requiring patches to be reviewed.
> > 
> > Good Luck,
> > Mark.
> > 
> > On Sat, 2002-12-07 at 08:09, Gnome CVS User wrote:
> > > CVSROOT:	/cvs/gnome
> > > Module name:	gnome-panel
> > > Changes by:	cneumair	02/12/06 14:09:48
> > > 
> > > Modified files:
> > > 	gnome-panel    : ChangeLog menu.c panel-config-global.c 
> > > 	                 panel-config-global.h 
> > > 	                 panel-global-config.schemas.in panel.c 
> > > 
> > > Log message:
> > > tooltips_enabled => enable_tooltips
> > > 
> > > URL : http://cvs.gnome.org/bonsai/cvsquery.cgi?module=gnome-panel&branch=&branchtype=match&dir=gnome-panel&file=&filetype=match&who=cneumair&whotype=match&sortby=Date&hours=&date=explicit&mindate=2002-12-06%2014:08&maxdate=2002-12-06%2014:10&cvsroot=/cvs/gnome
-- 

  Jeder erbärmliche Tropf, der nichts in der Welt hat, darauf er stolz
seyn könnte,
  ergreift das letzte Mittel, auf die Nation, der er gerade angehört,
stolz zu seyn.

	Artur Schopenhauer, Parerga und Paralipomena

_______________________________________________
gnome-hackers mailing list
gnome-hackers gnome org
http://mail.gnome.org/mailman/listinfo/gnome-hackers