Re: URIs vs. half-baked URIs [glib PATCH]



On Wed, 8 Aug 2001, Darin Adler wrote:

> On Wednesday, August 8, 2001, at 01:00  PM, Alex Larsson wrote:
>
> > Ok. New version. This one includes g_ascii_isspace() that i needed for the
> > gtk fileselector dnd thing.
>
> Is there a reason you couldn't use the <ctype.h> isspace function? I added
> g_ascii_xxx functions for things that I knew were different depending on
> the locale. I was under the impression that locales generally don't change
> the definition of isspace. On the other hand, perhaps locales do. If so,
> perhaps we should add a full complement for consistency, rather than
> adding the calls one at a time.

Well. I used isspace() in my gtkfilesel dnd patch, and owen said i should
use g_ascii_isspace(). It didn't exist, but seemed to make sense, so i
added it.

The man page says:
  isspace()
      checks for white-space characters.  In the "C" and "POSIX"
      locales, these are: space, form-feed ('\f'),  new­
      line ('\n'), carriage return ('\r'), horizontal tab ('\t'),
      and vertical tab ('\v').

I'm interpreting this as "may differ on other locales". But I don't know
if it actually does in any currently used locale.

> This comment still talks about the C library isalpha function, and
> mentions ASCII letters.

Oops.

/ Alex


_______________________________________________
gnome-hackers mailing list
gnome-hackers gnome org
http://mail.gnome.org/mailman/listinfo/gnome-hackers




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]