Nautilus String Freeze Break Request



Hello,

I'd like to request a string freeze break for committing the patch at
http://bugzilla.gnome.org/show_bug.cgi?id=167344 to the gnome-2.10
branch of nautilus. I don't know much about I18n issues, but it was
suggested that this is a critical bug for languages without plural forms
which should be fixed on the stable branch too. I'm attaching the patch
for convenience.

Martin

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/nautilus/ChangeLog,v
retrieving revision 1.6409
diff -u -r1.6409 ChangeLog
--- ChangeLog	17 Feb 2005 02:58:45 -0000	1.6409
+++ ChangeLog	17 Feb 2005 18:36:52 -0000
@@ -1,3 +1,9 @@
+2005-02-18  Changwoo Ryu  <cwryu debian org>
+
+	* src/file-manager/fm-directory-view.c (real_update_menus)
+	(real_update_menus): Fixed a string conflict between the c-format
+	plural string and non-c-format strings.  Bug #167344.
+
 2005-02-17  Martin Wehner  <martin wehner epost de>
 
 	* src/nautilus-navigation-window-menus.c:
Index: src/file-manager/fm-directory-view.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/file-manager/fm-directory-view.c,v
retrieving revision 1.660
diff -u -r1.660 fm-directory-view.c
--- src/file-manager/fm-directory-view.c	9 Feb 2005 10:51:53 -0000	1.660
+++ src/file-manager/fm-directory-view.c	17 Feb 2005 18:36:53 -0000
@@ -6225,10 +6225,10 @@
 
 	show_open_alternate = file_list_all_are_folders (selection);
 	if (nautilus_window_info_get_window_type (view->details->window) == NAUTILUS_WINDOW_NAVIGATION) {
-		if (selection_count == 0) {
+		if (selection_count == 0 || selection_count == 1) {
 			label_with_underscore = g_strdup (_("Open in New Window"));
 		} else {
-			label_with_underscore = g_strdup_printf (ngettext("Open in New Window",
+			label_with_underscore = g_strdup_printf (ngettext("Open in %d New Window",
 									  "Open in %d New Windows",
 									  selection_count), 
 								 selection_count);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]