Re: [BUG?] Issues in recent doc switch for gnome-panel

[Luca Ferretti <elle uca libero it>]

Il giorno mer, 20/07/2005 alle 19.14 -0500, Shaun McCance ha scritto:
> On Wed, 2005-07-20 at 10:17 +0200, Luca Ferretti wrote:
> > I'm porting Italian user's guide in gnome-panel package to recently
> > switched gnome-doc-utils. There are 3 issues:
> > 
> >      1. Figures are not installed. See the console log[1] for clock. In
> >         Makefile there are those entries[2], but no DOC_FIGURES is
> >         declared. So I suppose it depends on some Makefile.am missing,
> >         but I did't explore it deeply.
> 

<snip>

> Right, so if DOC_FIGURES isn't given explicitly, it should default to
> whatever png files are in C/figures.  I did just commit a change to
> how _DOC_LC_FIGURES and _DOC_SRC_FIGURES were determined, but I don't
> see that it would affect this problem.

Maybe.

> Since I can't reproduce this or #311007, I haven't a clue what's
> really going on here.  More eyeballs, please.

I did a small test[1] on fish, clock (w localized figures),  window-list
(w/o localized figures).

Using g-d-u 0.3.2 if you don't declare DOC_FIGURES in Makefile.am images
will be ignored. This variable needs the 'full relative' path to all
images you want to install. See following reduced installation logs

### Clock ###

     1. Add "DOC_FIGURES = figures/clocl_applet.png" to Makefile.am and
        regenerate Makefile
     2. The file figures/clock_applet.png is available in C and it
        directories
        
/bin/sh ../../mkinstalldirs /.../help/clock/C
/bin/sh ../../mkinstalldirs /.../help/clock/it
/usr/bin/install -c -m 644 C/legal.xml /.../clock/C/legal.xml
/usr/bin/install -c -m 644 C/clock.xml /.../clock/C/clock.xml
/usr/bin/install -c -m 644 it/legal.xml /.../clock/it/legal.xml
/usr/bin/install -c -m 644 it/clock.xml /.../clock/it/clo ck.xml
/bin/sh ../../mkinstalldirs /.../clock/C/figures/
mkdir -p -- /.../clock/C/figures/
/usr/bin/install -c -m 644 C/figures/clock_applet.png /.../clock/C/figures/clock_applet.png
/bin/sh ../../mkinstalldirs /../clock/it/figures/
mkdir -p -- /../clock/it/figures/
/usr/bin/install -c -m 644 it/figures/clock_applet.png /../clock/it/figures/clock_applet.png
/bin/sh ../../mkinstalldirs /usr/local/share/omf/clock
mkdir -p -- /usr/local/share/omf/clock
/usr/bin/install -c -m 644 clock-C.omf /usr/local/share/omf/clock/clock-C.omf
/usr/bin/install -c -m 644 clock-it.omf /usr/local/share/omf/clock/clock-it.omf
scrollkeeper-update -p /var/lib/scrollkeeper -o /usr/local/share/omf/clock
make[1]: Leaving directory `/home/GNOME2.10/gnome-panel/help/clock'

So it's OK

### Window List ###

     1. Add "DOC_FIGURES = figures/window_list_applet.png
        figures/window_list_group_applet.png" to Makefile.am and
        regenerate Makefile
     2. The PNG files are only in C directory

/bin/sh ../../mkinstalldirs /.../window-list/C
/bin/sh ../../mkinstalldirs /.../window-list/it
/usr/bin/install -c -m 644 C/legal.xml /.../window-list/C/legal.xml
/usr/bin/install -c -m 644 C/window-list.xml /.../window-list/C/window-list.xml
/usr/bin/install -c -m 644 it/window-list.xml /.../window-list/it/window-list.xml
/usr/bin/install -c -m 644 it/legal.xml /.../window-list/it/legal.xml
/bin/sh ../../mkinstalldirs /.../window-list/C/figures/
mkdir -p -- /.../window-list/C/figures/
/usr/bin/install -c -m 644 C/figures/window_list_applet.png /.../window-list/C/figures/window_list_applet.png
/usr/bin/install -c -m 644 C/figures/window_list_applet.png /.../window-list/it/figures/window_list_applet.png
/usr/bin/install -c -m 644 C/figures/window_list_group_applet.png /.../window-list/C/figures/window_list_group_applet.png
/usr/bin/install -c -m 644 C/figures/window_list_group_applet.png /.../window-list/it/figures/window_list_group_applet.png
/bin/sh ../../mkinstalldirs /opt/gnome210/share/omf/window-list
/usr/bin/install -c -m 644 window-list-C.omf /opt/gnome210/share/omf/window-list/window-list-C.omf
/usr/bin/install -c -m 644 window-list-it.omf /opt/gnome210/share/omf/window-list/window-list-it.omf
scrollkeeper-update -p /var/lib/scrollkeeper -o /opt/gnome210/share/omf/window-list

So this is OK: when there are no localized images, images under C will
be used

### Fish ###

     1. Add "DOC_FIGURES = fish_applet.png" to Makefile.am and
        regenerate Makefile
     2. Note the missing figures/ directory in previous declaration

<snip>
/usr/bin/install -c -m 644 ./C/fish_applet.png /.../fish/C/fish_applet.png
/usr/bin/install: cannot stat `./C/fish_applet.png': No such file or directory
/usr/bin/install -c -m 644 ./C/fish_applet.png /.../fish/it/fish_applet.png
/usr/bin/install: cannot stat `./C/fish_applet.png': No such file or directory
make[1]: *** [install-fig] Error 1

:-(

### Personal comments ###

IMHO the Fish example should work. As well as you declare only
"basenamed" XML filenames in DOC_INCLUDES, I suppose the DOC_FIGURES
should accept "basenamed" PNG filenames. And it should be the right
synopsis.

Maybe a DOC_FIGURES_DIR (or DOC_FIGURES_DIRS) variable could be useful,
if images aren't under XX/figures/ (but for example under XX/images).