Re: Funy focus behavior with OOo-1.1

[Michael Meeks <michael ximian com>]

Hi,

On Sun, 2003-10-26 at 01:48, Havoc Pennington wrote:
> Yeah, I thought that might happen. The window list or metacity needs to
> be adjusted to special-case UTILITY windows. However fixing OO.org to
> mark the windows as the proper type is the first step.

	So - that's substantially done - at least in our local patches.

> The patch to windowlist/metacity should be trivial, just find where it
> focuses transients and add "if (type == UTILITY) don't do that"

	I've implemented / tested this libwnck fix - may I commit to gnome-2-4
/ HEAD ?

	Thanks,

		Michael.

--- ChangeLog	31 Jul 2003 10:08:02 -0000	1.174.2.19
+++ ChangeLog	27 Oct 2003 09:59:36 -0000
@@ -1,3 +1,9 @@
+2003-10-27  Michael Meeks  <michael ximian com>
+
+	* libwnck/window.c (find_last_transient_for): when
+	activating, prefer the main window over a utility
+	transient.
+
 2003-07-29  Arvind Samptur <arvind samptur wipro com>
 
 	* libwnck/xutils.c (_wnck_get_utf8_list): Number of
--- libwnck/window.c	23 Jan 2003 02:12:21 -0000	1.33.2.1
+++ libwnck/window.c	27 Oct 2003 09:59:37 -0000
@@ -1010,7 +1010,8 @@ find_last_transient_for (GList *windows,
     {
       WnckWindow *w = tmp->data;
 
-      if (w->priv->transient_for == xwindow)
+      if (w->priv->transient_for == xwindow &&
+	  w->priv->wintype != WNCK_WINDOW_UTILITY)
         retval = w;
       
       tmp = tmp->next;

-- 
 michael ximian com  <><, Pseudo Engineer, itinerant idiot