Re: patch for gnome-libs/libgnome (include of gnome-defs.h in files using BEGIN_GNOME_DECLS)



Gediminas Paulauskas <menesis delfi lt> writes: 
> 
> so, the patch is good, and does very useful thing -- if you need only
> gnome-i18n.h, include it, and do not worry about gnome-defs.h. IMHO it
> must be applied, because it doesn't break anything, but fixes annoying
> problem.
> 

The problem with the patch is the usual one with this kind of fix, if
someone only tests their app compilation with gnome-libs most recent,
they will end up forcing all their users to upgrade gnome-libs to
compile the app. (And the error message on failure to compile will be
obscure.)

Havoc




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]