Re: [PATCH] global (MacOS Style) menubar applet [second attempt]

[Mark <jamess1 wwnet com>]

Jacob Ulysses Berkman wrote:
> 
> Mark <jamess1 wwnet com> writes:
> 
> > Hello,
> >
> > I've put up a new global menu patch here:
> >
> > http://www.wwnet.net/~jamess1/global-menu-patch.tar.gz
> >
> > This patch is against the current stable libraries. If this looks good I
> > will continue and make a gnome 2.0 patch.
> 
> So, I actually applied this patch and used it :)

Great.

> 
> There are a couple of minor problems with the patch (gnome-app.c
> including gnorba.h, bonobo-socket.[ch] including
> <bonobo/bonobo-socket.h> rather than "bonobo.h").

I was having trouble linking with bonobo, so I just included it for now.

> 
> Other than that, it works pretty well.  It crashed both the panel and
> apps at different times, though.
> 
> Some thoughts:
> 
>         * It would be nice if the apps could determine that the
>           swallower is running, and then only pop up the submenus if
>           this is the case.  This is probably Hard.  KDE does not
>           solve this AFAIK.

I'm not sure what you mean by this, I did put a preference which the app
should check. I the preference was missing from my upload, it should be
there now.

> 
>         * Integration into the foobar: if it's there, people would
>           probably want the menu there.

Yup.

> 
>         * Was there something from gnome-preferences.[ch] not included
>           with the patch?

I was afraid I would forget something. Try downloading again, I included
the preference setting stuff this time.

> I will hopefully look into the crashing and mis-focusing later.

Great.

Mark