Re: Several diffs for GNOME CVS packages for Solaris 2.5.1

[Owen Taylor <otaylor redhat com>]

"Brandon S. Allbery" <allbery@ece.cmu.edu> writes:

> This includes the gnome-libs/zvt patch I posted earlier and the ORBit/popt
> patch that nobody seems to care about :-( (I submitted it to ewt@redhat.com
> and got no response, as well as filing a GNOME bug report that has been
> ignored).

I think that the problem here is that ORBit has a slightly
out of date version of popt that doesn't have all the
latest configuration changes. Hopefully, now that Elliot
is back working at Red Hat, he can get together 
with Jeff Johnson (who has taken over maintainership
of popt from Erik Troan) and solve that probem.

> mc/gnome:  undefined MAX() on Solaris (<= 2.5.1?)
> 	   typo in non-glibc2.1 STREAMS pty handling
> 
> Index: mc/gnome/gscreen.c
> ===================================================================
> RCS file: /cvs/gnome/mc/gnome/gscreen.c,v
> retrieving revision 1.215
> diff -u -r1.215 gscreen.c
> --- mc/gnome/gscreen.c	1999/04/18 06:57:37	1.215
> +++ mc/gnome/gscreen.c	1999/05/23 16:09:13
> @@ -39,6 +39,9 @@
>  #include <gdk/gdkprivate.h>
>  #include <glib.h>
>  
> +#ifndef MAX
> +#define MAX(a,b) ((a)>(b)?(a):(b))
> +#endif
>  /* Whether to display the tree view on the left */
>  int tree_panel_visible = -1;

This patch looks highly dubious, since glib.h defines
MAX.

                                        Owen