Re: [gnome-db] patch : gda-postgres remove-row.



On Fri, 2005-01-07 at 11:20 +1000, Bas Driessen wrote:
> 
> > I've looked at the patch and it looks ok for me, except for the row
> > flagged as "R" which in fact remains in the data model (which means
> > other function on the data model will retyurn wrong results).
> 
> The row-id should not be confused with the row-number. Row-number
> (gda_row_get_number) contains the number of the row in a data model and
> I do not touch that, while row-id (gda_row_get_id) contains any
> additional identifier. This field is not used until now in libgda itself
> (besides being set by the postgres provider), so we may as well start
> using it.
> 
> Also, do I need to trigger a "gda_data_model_changed" or/and
> "gda_data_model_row_removed"?
> 
yes, since you need to notify of the changes.
-- 
Rodrigo Moya <rodrigo gnome-db org>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]