Re: [gnome-db] Some bugs to libgda and libgnomedb (1.2)



On Tue, 2005-02-01 at 16:54 +0100, ALVAROPG telefonica net wrote:
> Hi all,
> 
>    Working with the GnomeDbGrid, I have found some bugs, when a new row
> is inserted, GdaDataModel emits the "row_inserted" signal, but
> GdaDataModel is a "interface", implemented by GdaDataModelArray, for
> example, and this array model emits the signal too. Then the GnomeDbGrid
> show 2 new rows.
> 
>    And When a row is removed, the GdaDataModelArray don't renumber the
> rows, like GnomeDbGrid with the DataModelInfo list.
> 
>    I attach the patches. I'm working with the 1.2 release, the HEAD
> sources don't compile.
> 
>    buff, sorry for my english.
> 


> +       for (i = 0; i < cols; i++) {
> +               value = (GdaValue *) gda_row_get_value ((GdaRow *)
> row, i);
> +               gda_value_set_string (value, "NULL");
>         }
why is this needed?

Apart from that, both patches look ok for the release-1-2-branch, so
please commit them there. The libgda part, I guess, looks also ok for
HEAD.
-- 
Rodrigo Moya <rodrigo gnome-db org>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]