Re: [gnome-db] [PATCH] gcc 3.4 compliance

[Jürg Billeter <j bitron ch>]

On Sam, 2004-05-08 at 21:54, Rodrigo Moya wrote:
> On Fri, 2004-05-07 at 23:03 +0200, Jürg Billeter wrote:
> > Hi
> > 
> > libgda and libgnomedb 1.1.2 don't compile with gcc 3.4.0; there occur
> > many "label at end of compund statement" errors. The attached patches
> > shall correct this build problem.
> > 
> this seems to be gcc being broken, that is, since when do you have to
> add empty statements to case blocks? I have seen this error reported
> somewhere else and the conclusion, IIRC, was that gcc 3.4 is broken.

Doesn't look like that: "The undocumented extension that allowed C
programs to have a label at the end of a compound statement, which has
been deprecated since GCC 3.0, has been removed."

http://gcc.gnu.org/gcc-3.4/changes.html

> At least, I'd add 'break;' lines, not just ';'.

AFAIR just ';' has been used in many patches for other packages, so I
thought to do the same.

Jürg