Re: [gnome-db] Libgda Firebird provider patch

[Rodrigo Moya <rodrigo gnome-db org>]

On Mon, 2004-07-19 at 11:33 +0000, Jeronimo Albi wrote:
> Rodrigo Moya wrote:
> 
> >On Thu, 2004-07-15 at 15:36 +0000, Jeronimo Albi wrote:
> >  
> >
> >>  Greetengs !!
> >>  Attached gziped patch for libgda Firebird provider with this e-mail.
> >> 
> >>  I corrected code syntax. I'd apreciate to know if I did it wrong.
> >>
> >>  Comments:
> >>     1. Function fb_get_affected_rows is not being used yet. It shoud 
> >>return
> >>         number of affected rows by a non select statement. Actually is 
> >>the only
> >>         warning at compilation.
> >>     2. If you want to drop a database you should be connected to the 
> >>database
> >>          that will be dropped. This is the way Firebirds API works. 
> >>I'll wait for
> >>          instructions about what to do with this issue. In the meantime 
> >>"name"
> >>          parameter is not being used.
> >>     3. I implemented gda_firebird_recordset_describe_column as you wanted.
> >>     4. Firebird uses "DOUBLE PRECISION" as a reserved word for that kind
> >>         of data type.
> >>
> >>  I'll send more modifications shortly. I'll add support for Blob data 
> >>type and
> >>for more schemas.
> >>
> >>    
> >>
> >I'm a bit lost on what is your latest patch, so could you answer to this
> >mail with the latest greatest patch, please?
> >
> >thanks
> >  
> >
> No problem, latest patch attached in this message.
> 
> Until now I sent 2 patches:
>     1. 070504-0   (first one)
>     2. 071504-0   (last one, with corrections of 1 and some new things)
> 
> A comment:
>     In this patch (071504-0) #gda_firebird_provider_drop_database is
> dropping connected database. I modified my code since i sent this patch,
> and i'll be short in time this 2 weeks so I can't correct
> #gda_firebird_provider_drop_database right now, but next patch will have
> this method corrected.
> 
ok, this patch is now applied to CVS HEAD.

Thanks a lot
-- 
Rodrigo Moya <rodrigo gnome-db org>