Re: [gnome-db] little patch for the gray bar
- From: Rodrigo Moya <rodrigo gnome-db org>
- To: ÁlvaroPeña <apg esware com>
- Cc: GDA <gnome-db-list gnome org>
- Subject: Re: [gnome-db] little patch for the gray bar
- Date: Wed, 01 Oct 2003 14:25:32 +0200
On Wed, 2003-10-01 at 01:34, ÁlvaroPeña wrote:
> Hi all!
> 
>    This is a patch for the gray bar, now don't make a g_free for the widgets
> into the bar, like the icon and label.
> 
>    Diffs for head and 1.0 branch. What do you think?
> 
it would much better if you checked bar->priv before using it. That is:
if (bar->priv) {
	bar->priv->label = NULL;
	...
	g_free (bar->priv);
	bar->priv = NULL;
}
please change that. Also, since the code is the same in both branches,
no need to send 2 patches, just send one, and then apply it to both
branches.
cheers
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]