Re: [gnome-db] Patch for GnomeDBGrid

[Rodrigo Moya <rodrigo ximian com>]

On Tue, 2003-12-16 at 15:32, Stéphane Wirtel wrote:
> In this patch, there are two functions.
> 
> diffstat libgnomedb-db_grid_set_get_column_title.patch
> 
>  gnome-db-grid.c |   53
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  gnome-db-grid.h |    2 ++
>  2 files changed, 55 insertions(+)
> 
> 
> 
> void gnome_db_grid_set_column_title(GnomeDbGrid *grid, gint col, const
> gchar *title);
> 
> This function change the title of a column of a dbgrid
> 
> 
> const gchar *gnome_db_grid_get_column_title(GnomeDbGrid *grid, gint col)
> 
> This function returns the title of a column.
> 
> Bye all, 
> 
the patch looks ok, except for some style issues:

+       g_return_if_fail(GNOME_DB_IS_GRID(grid));

the coding standards we use (HACKING file) say that after the function
name, and before the opening paren, we leave a space. So, this should be

	g_return_if_fail (GNOME_DB_IS_GRID (grid));

There are many places that need that extra space.

+       if ( list != NULL ) 
+       {
we don't put the opening brace in its own line, but in the same line as
the if statement. Also, remove the space between the '(' and 'list' and
between 'NULL' and ')'. So, this should be:

	if (list != NULL) {

apart from that, it looks ok, and was going to commit it, but it seems
to not apply correctly. It says:

patch: **** malformed patch at line 62: diff -Nru
libgnomedb/libgnomedb/gnome-db-grid.h
libgnomedb.matrixise/libgnomedb/gnome-db-grid.h

so, please, could you resend it? Make sure you just run:

	cvs -z3 diff -u > /tmp/libgnomedb.diff

thanks for the patch