Re: [gnome-db] Big patch

[Rodrigo Moya <rodrigo gnome-db org>]

On Mon, 2002-05-13 at 00:20, Gonzalo Paniagua Javier wrote:
> 	The attached patch and files:
> 
> 		* Remove gda-recordset.[ch].
> 		
> 		* Add a new gda-data-model-hash which is is used by the
> 		postgres provider.
> 		
> 		* Removes GdaField.
> 
> 		* Makes GdaRow store an array of GdaValue instead of a
> 		GList of GdaField and remove gda-row-attributes-*.
> 
> 		* Fixes some warning.
> 
> 		* Removes dead code (never executed) from
> 		gda-data-model-array.c
> 
> 		* Changes to the postgres recordset to implemente
> 		GdaDataModelHash.
> 
> 		* A new test under postgres to test speed in random access to
> 		values.
> 
> 	Comments?
> 
looks ok, except for this:

> Index: libgda/gda-table.c
> ===================================================================
> RCS file: /cvs/gnome/libgda/libgda/gda-table.c,v
> retrieving revision 1.6
> diff -u -r1.6 gda-table.c
> --- libgda/gda-table.c	22 Apr 2002 22:01:33 -0000	1.6
> +++ libgda/gda-table.c	12 May 2002 08:52:17 -0000
> @@ -199,6 +199,7 @@
>  
>  		fa = gda_data_model_describe_column (GDA_DATA_MODEL (model), n);
>  		gda_table_add_field (table, (const GdaFieldAttributes *) fa);
> +		gda_field_attributes_free (fa);
>  	}
>  
why do you remove this line?

> Index: libgda/libgda.h
> ===================================================================
> RCS file: /cvs/gnome/libgda/libgda/libgda.h,v
> retrieving revision 1.13
> diff -u -r1.13 libgda.h
> --- libgda/libgda.h	4 May 2002 16:39:36 -0000	1.13
> +++ libgda/libgda.h	12 May 2002 08:52:17 -0000
> @@ -38,7 +38,6 @@
>  #include <libgda/gda-log.h>
>  #include <libgda/gda-parameter.h>
>  #include <libgda/gda-quark-list.h>
> -#include <libgda/gda-recordset.h>
>  #include <libgda/gda-row.h>
>  #include <libgda/gda-table.h>
>  #include <libgda/gda-util.h>
>
here, include gda-data-model-hash.h also

cheers