Re: [gnome-db] New patch. Closes bug #68577



On Thu, 2002-01-17 at 02:43, Gonzalo Paniagua Javier wrote:
> 	Here is a patch that adds a new parameter to the executeCommand
> 	function in the IDL and changes some files in libgda/libgda to
> 	adopt the new interface along with the proper changes to the
> 	provider and test for psotgres.
> 
I am thinking that it would be better to add a new member to the Command
structure (CommandOption), and don't add the new parameter at all, but
use the already passed GNOME::Database::Command structure to pass thins
information.

Sounds good? If so, could you please provide a new patch? It involves
much less changes, that is:

* add CommandOption member to the Command struct in IDL
* add get_/set_ methods in gda-command.[ch] for this new member.
* in the providers, use this new member on the already existing command
parameter to determine whether to stop or continue on errors

cheers
-- 
Rodrigo Moya <rodrigo gnome-db org> - <rodrigo ximian com>
http://www.gnome-db.org/ - http://www.ximian.com/



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]