Re: [gnome-db] Getting gnome-db to work with postgres 7.2

[Rodrigo Moya <rodrigo gnome-db org>]

On Sat, 2002-04-20 at 23:39, Joseph Wang wrote:
>   I've been poking around gda and I think I've found the problem
> that keeps gda from working with postgres 7.2.
> 
> pg_attribute no longer has the oid so that gda-postgres-connection.c
> breaks in getting that information. Fortunately the only use for that
> bit of information seems to be in creating comments. The oid's for
> the other system tables are still there.
> 
> 
> 
> --- 
> libgda-0.2.9/providers/gda-postgres-server/gda-postgres-connection.c.orig
> 2002-04-20 13:13:42.000000000 -0500
> +++ libgda-0.2.9/providers/gda-postgres-server/gda-postgres-connection.c
> 2002-04-20 13:15:29.000000000 -0500
> @@ -955,7 +955,8 @@
> "NOT(b.attnotnull) AS \"Nullable\", "
> "textcat('%s ', b.attnum) AS \"Key\", "
> "textcat('%s ', b.attname) AS \"Default Value\", "
> - "obj_description(b.oid) AS \"Comments\" "
> + /* "obj_description(b.oid) AS \"Comments\" " */
> + "'' AS \"Comments\" "
> "FROM pg_type c, "
> "pg_attribute b, "
> "pg_class a "
> 
hmm, this will break pre-7.2 support, since in pre-7.2 versions, that
query works, and really returns the comments for that field, so, I'm
afraid we can't accept your patch :-(

But, please, help us in finding the correct way for fixing it and making
it work as expected (return the comments for that field) for all
versions.

Gonzalo, Vivien, any idea?

cheers
-- 
Rodrigo Moya <rodrigo gnome-db org> - <rodrigo ximian com>
http://www.gnome-db.org/ - http://www.ximian.com/