Re: bonobo_get_object_async (take 2)...



On Fri, 2006-02-03 at 15:44 +0000, Mark McLoughlin wrote:
> Hi Rodrigo,
> 	It's pretty bad form to send completely untested patches ...
> 
> On Fri, 2006-02-03 at 16:31 +0100, Rodrigo Moya wrote:
> > -       bonobo_get_object_async (moniker, "IDL:Bonobo/Control:1.0", &ev,
> > -                                (BonoboMonikerAsyncFn) panel_applet_frame_activated,
> > -                                frame_act);
> > +       bonobo_activation_activate_from_id_async ("IDL:Bonobo/Control:1.0", 0,
> > +                                                 (BonoboActivationCallback) panel_applet_frame_activated,
> > +                                                 frame_act, &ev); 
> 
> 	Two problems here:
> 
>   1) bonobo-activation clearly doesn't support activating an interface
>      name
> 
>   2) Even if you did pass the OAFIID moniker string instead of the 
>      interface name, it would still break since this is one of the few 
>      places in GNOME that actually does still use the moniker system 
>      for the Bonobo::ItemContainer interface
> 
right, the patch is totally wrong, sorry.
-- 
Rodrigo Moya <rodrigo novell com>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]