Re: bonobo_get_object_async (take 2)...



Hi Michael,

On Fri, 2006-02-03 at 15:03 +0000, michael meeks wrote:
> Hi Mark,
> 
> 	Please find attached trivial patch to gnome-session making the vino
> activation (more) truly async & hence not blocking login etc. until it's
> started :-) [ should also avoid loading those pesky moniker libraries
> too I think ;-] (can I/Rodrigo commit & to the stable branch too ?).

	Yep, that looks good.

>    /* Strip off the screen portion of the display */
>    p = strrchr (display_name, ':');
>    if (p)
> @@ -59,6 +60,7 @@
>        if (p)
>  	p [0] = '\0';
>      }
> +#endif
>  
>    reg_env = bonobo_activation_registration_env_set (reg_env, "DISPLAY", display_name);
>    result = bonobo_activation_register_active_server (VINO_SERVER_IID,
> 
> 	Briefly - why is that mangling of the DISPLAY variable necessary ? I
> must confess that even without it vino fails to launch properly ;-) so
> is there some cockup with gnome-session & the way it activates stuff
> too ?

	We strip off the screen number from the display name so that the object
is registered per-display rather than per-screen. We want a copy of vino
per-display rather than per-screen since vino can handle multiple
screens.

Cheers,
Mark.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]