Re: Patch for bonobo-ui-sync-status.c

[Michael Meeks <michael ximian com>]

Hi Paolo,

On Tue, 2002-02-26 at 11:52, Paolo Maggi wrote:
> 	here you can find a simple patch for bonobo-ui-sync-status.c

	Great - it looks nice, but I think we need to get the flow a bit
better:

> -		if (resize_grip && atoi (resize_grip) == 0)
> -			gtk_statusbar_set_has_resize_grip (msync->main_status,
> -							   FALSE);
> -
> +		if (resize_grip) {
> +			if (atoi (resize_grip) == 0)				
> +				gtk_statusbar_set_has_resize_grip (
> +						msync->main_status, FALSE);
> +			else
> +				gtk_statusbar_set_has_resize_grip (
> +						msync->main_status, TRUE);
> +		}

	I think we need to have something like:

	has_grip = FALSE;
	if (resize_grip && atoi (resize_grup) != 0)
		resize_grip = TRUE;

	gtk_statusbar ...

	Otherwise if people delete the attribute having had it set to some
state - they are left with an un-defined state lurking around :-)

	With that change, please do commit,

	Thanks,

		Michael.

>  		
>  		id_str = bonobo_ui_engine_node_get_id (sync->engine, node);
>  
-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot