Re: FreeBSD oaf fix

[Maciej Stachowiak <mjs noisehavoc org>]

On 02Sep2001 01:27AM (-0700), Chris Toshok wrote:
> Evolution has hung on startup on FreeBSD (all versions I've tested along
> the 4.x branch, and I assume the 5.x stuff as well) for some time now. 
> This patch to OAF (the oaf-stable-0-6 branch) fixes the problem.  I've
> run evolution on Linux with the fix and haven't noticed a change.
> 
> Considering this fix isn't needed to keep things working on the other
> platforms evolution supports (linux, solaris) there's obviously some
> discrepancy in the handling of signal masks (specifically those which
> block SIGCHLD) between these platforms.  Not sure which platform(s) are
> the ones with the bug, honestly, or if the correct behavior is even
> specified someplace.
> 

I've already approved this change for oaf HEAD and bonobo-activation
HEAD in private mail. I guess Chris's mail finally got approved for
the list. :-)

> Index: oaf-fork-server.c
> ===================================================================
> RCS file: /cvs/gnome/oaf/liboaf/oaf-fork-server.c,v
> retrieving revision 1.1.2.3
> diff -c -u -r1.1.2.3 oaf-fork-server.c
> --- oaf-fork-server.c	2001/07/22 18:14:46	1.1.2.3
> +++ oaf-fork-server.c	2001/09/02 08:23:59
> @@ -267,6 +267,7 @@
>  		if (od_iorstr)
>  		  oaf_setenv ("OAF_OD_IOR", od_iorstr);
>                  
> +		sigprocmask (SIG_SETMASK, &omask, NULL);
>  
>  		close (iopipes[0]);
>