Re: bonobo-activation reference leak ...

[Michael Meeks <michael ximian com>]

On Thu, 25 Oct 2001, Maciej Stachowiak wrote:
> Yes, assuming that you've tested that this change is safe.

	Naturaly, in fact in the latest bonobo it moans about leaked
references if you don't have the patch :-) - the power of debugging.

> Also, is this change needed in oaf as well?

	Well - it's hardly serious really - so no point really.

> As an aside, it might be nice to add an shlib test to the
> bonobo-activation test suite sometime.

	We have some in libbonobo thankfully so it's not that desparate.

	Regards,

		Michael.

>
> Regards,
>
> Maciej
>
>
> > 	Thanks,
> >
> > 		Michael.
> >
> > Index: ChangeLog
> > ===================================================================
> > RCS file: /cvs/gnome/bonobo-activation/ChangeLog,v
> > retrieving revision 1.234
> > diff -u -r1.234 ChangeLog
> > --- ChangeLog	2001/10/17 19:53:26	1.234
> > +++ ChangeLog	2001/10/25 06:53:34
> > @@ -1,3 +1,9 @@
> > +2001-10-26  Michael Meeks  <michael ximian com>
> > +
> > +	* bonobo-activation/bonobo-activation-shlib.c
> > +	(bonobo_activation_activate_shlib_server): don't leak the POA
> > +	reference we obtained.
> > +
> >  2001-10-17  Louise Miller <louise miller sun com>
> >
> >  	* idl/Bonobo_ActivationContext.idl,idl/Bonobo_Activation_types.idl, idl/Bonobo_ObjectDirectory.idl
> > Index: bonobo-activation/bonobo-activation-shlib.c
> > ===================================================================
> > RCS file: /cvs/gnome/bonobo-activation/bonobo-activation/bonobo-activation-shlib.c,v
> > retrieving revision 1.25
> > diff -u -r1.25 bonobo-activation-shlib.c
> > --- bonobo-activation/bonobo-activation-shlib.c	2001/09/26 07:58:00	1.25
> > +++ bonobo-activation/bonobo-activation-shlib.c	2001/10/25 06:53:35
> > @@ -226,6 +226,8 @@
> >                  g_free (error_string);
> >          }
> >
> > +        CORBA_Object_release ((CORBA_Object) poa, ev);
> > +
> >  	return retval;
> >  }
> >
> >
> > --
> >  mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot
> >
> > _______________________________________________
> > gnome-components-list mailing list
> > gnome-components-list gnome org
> > http://mail.gnome.org/mailman/listinfo/gnome-components-list
>

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot