zoomable bug (wontfix)
- From: Michael Meeks <michael ximian com>
- To: Darin Adler <darin eazel com>
- Cc: <gnome-components-list gnome org>
- Subject: zoomable bug (wontfix)
- Date: Tue, 6 Nov 2001 20:50:50 -0500 (EST)
Since it seems that in Gnome 1.4 no-one can set the preferred
names on the zoomable, since the array size is not set correctly - it
strikes me that fixing this might provoke some nautilus code paths that we
don't want to hit - or that it is unneccessary; either way I won't apply
this unless you want it; it's in libbonoboui of course;
Regards,
Michael.
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/bonobo/ChangeLog,v
retrieving revision 1.1140
diff -u -p -u -r1.1140 ChangeLog
--- ChangeLog 2001/11/06 23:01:07 1.1140
+++ ChangeLog 2001/11/07 01:47:45
@@ -1,3 +1,9 @@
+2001-11-06 Michael Meeks <michael ximian com>
+
+ * bonobo/bonobo-zoomable.c
+ (bonobo_zoomable_set_parameters_full): fix segv; this
+ routine sucks very badly.
+
2001-11-06 Federico Mena Quintero <federico ximian com>
Fix Ximian bug #6150.
cvs server: Diffing bonobo
Index: bonobo/bonobo-zoomable.c
===================================================================
RCS file: /cvs/gnome/bonobo/bonobo/bonobo-zoomable.c,v
retrieving revision 1.16
diff -u -p -u -r1.16 bonobo-zoomable.c
--- bonobo/bonobo-zoomable.c 2001/02/17 00:22:09 1.16
+++ bonobo/bonobo-zoomable.c 2001/11/07 01:47:47
@@ -589,7 +589,7 @@ bonobo_zoomable_set_parameters_full (Bon
bonobo_zoomable_free_preferred_zoom_level_arrays (p);
p->priv->preferred_zoom_levels = g_array_new (FALSE, TRUE, sizeof (float));
-
+
if (preferred_zoom_levels) {
g_array_append_vals (p->priv->preferred_zoom_levels,
preferred_zoom_levels,
@@ -599,7 +599,7 @@ bonobo_zoomable_set_parameters_full (Bon
p->priv->preferred_zoom_level_names = g_array_new (FALSE, TRUE, sizeof (gchar *));
if (preferred_zoom_level_names) {
- g_array_set_size (p->priv->preferred_zoom_levels, num_preferred_zoom_levels);
+ g_array_set_size (p->priv->preferred_zoom_level_names, num_preferred_zoom_levels);
zoom_level_names = (gchar **) p->priv->preferred_zoom_level_names->data;
for (i = 0; i < p->priv->preferred_zoom_level_names->len; ++i) {
zoom_level_names [i] = g_strdup (preferred_zoom_level_names [i]);
--
mmeeks gnu org <><, Pseudo Engineer, itinerant idiot
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]