warning-reducing patch for libbonobo



This patch removes some redundant macros from configure.in and makes bonobo_arg_is_equal work for const BonoboArg * parameters (which some callers are passing). It's the kind that I'd often just commit, but I decided to ask for approval anyway since I'm just starting to do GNOME 2 work.

OK to commit?

Index: configure.in
===================================================================
RCS file: /cvs/gnome/libbonobo/configure.in,v
retrieving revision 1.19
diff -p -u -r1.19 configure.in
--- configure.in	2001/07/10 17:42:04	1.19
+++ configure.in	2001/07/13 16:09:46
@@ -22,9 +22,7 @@ GNOME_PLATFORM_GNOME_2(yes, force)
 AC_ISC_POSIX
 AC_PROG_CC
 AC_STDC_HEADERS
-AC_ARG_PROGRAM
 AM_PROG_LIBTOOL
-AM_PROG_LEX
 AC_PROG_YACC
 AC_PATH_PROGS(PATH_TO_XRDB, "xrdb")

Index: bonobo/bonobo-arg.c
===================================================================
RCS file: /cvs/gnome/libbonobo/bonobo/bonobo-arg.c,v
retrieving revision 1.20
diff -p -u -r1.20 bonobo-arg.c
--- bonobo/bonobo-arg.c	2001/07/11 14:32:34	1.20
+++ bonobo/bonobo-arg.c	2001/07/13 16:09:47
@@ -344,7 +344,7 @@ bonobo_arg_type_is_equal (BonoboArgType
  * Return value: TRUE if @a == @b
  **/
 gboolean
-bonobo_arg_is_equal (BonoboArg *a, BonoboArg *b, CORBA_Environment *opt_ev) +bonobo_arg_is_equal (const BonoboArg *a, const BonoboArg *b, CORBA_Environment *opt_ev)
 {
 	CORBA_Environment ev, *my_ev;
 	gboolean retval;
@@ -356,7 +356,7 @@ bonobo_arg_is_equal (BonoboArg *a, Bonob
 	} else
 		my_ev = opt_ev;

-	retval = ORBit_any_equivalent (a, b, my_ev);
+ retval = ORBit_any_equivalent ((CORBA_any *) a, (CORBA_any *) b, my_ev);

 	if (!opt_ev)
 		CORBA_exception_free (&ev);
Index: bonobo/bonobo-arg.h
===================================================================
RCS file: /cvs/gnome/libbonobo/bonobo/bonobo-arg.h,v
retrieving revision 1.19
diff -p -u -r1.19 bonobo-arg.h
--- bonobo/bonobo-arg.h	2001/06/26 16:43:32	1.19
+++ bonobo/bonobo-arg.h	2001/07/13 16:09:47
@@ -80,8 +80,8 @@ void          bonobo_arg_to_gtk        (

 GType         bonobo_arg_type_to_gtk   (BonoboArgType      id);

-gboolean      bonobo_arg_is_equal      (BonoboArg         *a,
-					BonoboArg         *b,
+gboolean      bonobo_arg_is_equal      (const BonoboArg   *a,
+					const BonoboArg   *b,
 					CORBA_Environment *opt_ev);

 gboolean      bonobo_arg_type_is_equal (BonoboArgType      a,

===================================================================

    -- Darin




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]