Re: moniker question

[Joe Shaw <joe ximian com>]

> The following patch will get rid of the hard-coded ebrowser in
> monikers/bonobo-moniker-http.c. See bonobo-moniker-gunzip.c for the
> analogy.

Eek. Can you resend these patches in diff -u format?

> I had to manually include bonobo/bonobo-moniker-extender.h. Did you
> forget to add this file to bonobo/bonobo.h?

I think the idea is to not include additional header files in bonobo.h to
keep the number of includes down and make compilation faster.

> As I said, you can easily add a bonobo-moniker-camera.c/h - simply take
> the bonobo-moniker-http.c/h and replace all "http" by "camera". As with
> the bonobo-moniker-http, which needs gtkhtml to be useful,
> bonobo-moniker-camera would need GnoCam. I think this is wrong. The
> functionality "hey:whatever" -> "libstorage_hey.so" should be in bonobo.

I'm not sure I understand what you mean, exactly. The moniker is just a
naming mechanism that uses the standard bonobo storage module stuff, so
doing the http fetching and such is all done in that module. The moniker
itself shouldn't (and doesn't) have anything to do with gtkhtml. The only
reason that ebrowser is hard-coded is because it wasn't finished. I
thought I had a FIXME in there, but I either forgot or it got taken
out. *shrug*

Joe