Re: libbonoboui patch

[Michael Meeks <michael ximian com>]

Hi Anders,

On Sat, 2001-12-29 at 21:03, Anders Carlsson wrote:
> the attached patch fixes an issue with icon sizes in the toolbar and
> adds suppoart for a resize_grip property for the statusbar which
> controls if the status bar should have a resize grip.

	Sounds fine to me overall;

> OK to commit?

	Sure - can you just 'fix' a few things:

> +		if (resize_grip) {
> +			if (!strcmp (resize_grip, "true")) {
> +				gtk_statusbar_set_has_resize_grip (
> +					msync->main_status, TRUE);
> +			}
> +			else if (!strcmp (resize_grip, "false")) {
> +				gtk_statusbar_set_has_resize_grip (
> +					msync->main_status, FALSE);
> +			}

	We typicaly use 'atoi' for boolean arguments - yes we could change this
but we should have a homogenous strategy, and currently that is integer
- can you fix that ? [ or make a routine that accepts yes/no,
true/false, integer etc. throught ].

> +			if (!strcmp (resize_grip, "true")) {
> +				gtk_statusbar_set_has_resize_grip (
> +					GTK_STATUSBAR (widget), TRUE);
> +			}

	Oh - and you only need one of these code sections - a 'sync' is always
done on a newly constructed node to avoid this sort of duplication; can
you cut it out of the 'build' ?

> Index: doc/ui-xml.txt

	Thanks for updating the docs, can you re-post the revised patch as you
commit ?

	Regards,

		Michael.

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot