Re: UPDATED (glib-gettextize patch)

[Darin Adler <darin bentspoon com>]

On 12/14/01 4:40 PM, "Miles Lane" <miles megapathdsl net> wrote:

> dnl Process this file with autoconf to produce a configure script.
> +
> AC_INIT(idl/Bonobo_ActivationContext.idl)

Gratuitous change. Why not leave it alone?

> +dnl Specify a header configuration file
> +AM_CONFIG_HEADER(config.h)

Reason for moving this?

> +BONOBO_ACTIVATION_VERSION=$BONOBO_ACTIVATION_MAJOR_VERSION.$BONOBO_ACTIVATION
> _MINOR_VERSION.$BONOBO_ACTIVATION_MICRO_VERSION
> +
> +AM_INIT_AUTOMAKE(bonobo-activation, $BONOBO_ACTIVATION_VERSION)

Reason for moving this?

> -AM_PROG_LEX
> +dnl AM_PROG_LEX

Please remove rather than commenting out. Are you sure it's OK to remove it?
I've seen the warning that inspired you to remove it, but I'm not sure.

> -AM_GNOME2_GETTEXT
> 
> -GNOME_COMMON_INIT
> +GETTEXT_PACKAGE=bonobo-activation
> +AC_SUBST(GETTEXT_PACKAGE)
> +AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, "$GETTEXT_PACKAGE")
> +
> +AM_GLIB_GNU_GETTEXT

This looks like the real change. This part I would approve for commit
without reservations, although I am slightly surprised that the
AC_DEFINE_UNQUOTED line is needed.

    -- Darin