Re: PATCH: bonobo-activation core dump on Solaris

[Laszlo PETER <Laszlo Peter ireland sun com>]

Havoc Pennington wrote:
> 
> Darin Adler <darin bentspoon com> writes:
> > This is going to be a non-trivial problem. The C-standard-required behavior,
> > where structure fields get zeroed out if they aren't mentioned, is something
> > we rely on in a number of other places in Gnome.
> 
> Maybe Forte works for "foo = { NULL, }" but not "foo = {}"?

Yes, it does.

> Then the problem would maybe be less common...

Actually bonobo-activation seems to be the only package where this is used.
The other places where I got the same warning were caused by an orbit-idl buglet.
So, may I commit this?

Laca

Index: bonobo-activation/bonobo-activation-init.c
===================================================================
RCS file: /sgnome/cvsroots/GNOME/bonobo-activation/bonobo-activation/bonobo-activation-init.c,v
retrieving revision 1.41
diff -u -r1.41 bonobo-activation-init.c
--- bonobo-activation/bonobo-activation-init.c	31 Oct 2001 00:58:41 -0000	
1.41
+++ bonobo-activation/bonobo-activation-init.c	5 Dec 2001 18:54:29 -0000
@@ -174,7 +174,7 @@
 bonobo_activation_internal_activation_context_get_extended (gboolean           existing_only,
                                                             CORBA_Environment *ev)
 {
-	BonoboActivationBaseService base_service = {};
+	BonoboActivationBaseService base_service = {NULL,};
 
 	base_service.name = "IDL:Bonobo/ActivationContext:1.0";
 	base_service.session_name = bonobo_activation_session_name_get ();
@@ -187,7 +187,7 @@
 CORBA_Object
 bonobo_activation_activation_context_get (void)
 {
-	BonoboActivationBaseService base_service = {};
+	BonoboActivationBaseService base_service = {NULL,};
 
 	base_service.name = "IDL:Bonobo/ActivationContext:1.0";
 	base_service.session_name = bonobo_activation_session_name_get ();
@@ -201,7 +201,7 @@
                           const char *hostname,
                           const char *domain)
 {
-        BonoboActivationBaseService base_service = {};
+        BonoboActivationBaseService base_service = {NULL,};
 
         base_service.name = "IDL:Bonobo/ObjectDirectory:1.0";
         base_service.session_name = bonobo_activation_session_name_get ();