Re: bonobo-ui-node re-write ...

[Martin Baulig <martin home-of-linux org>]

Michael Meeks <michael ximian com> writes:

> > Overall, the change seems like a great idea. It does seem gratuitous
> > to make the code rely on the BonoboUINode structure rather than
> > continuing to use function calls to get things like next, previous,
> > and parent. If that change results in a measurable speedup, then I
> > guess it's worth it, but I doubt it does. Keeping the abstraction if
> > it's not prohibitively expensive might make it easier to make a future
> > change in this area.
> 
> 	Gnome 1.4 is end of development lifetime and well into maintenance
> mode I hope, and I cannot envisage us switching to another UI node
> structure any time soon - so this doesn't worry me. But I agree, I only
> did the switch where I was supicious that I'd seen the method on a profile
> in the past ( not a good optimization heuristic though ).

Hmm, why don't we just use a macro or inline function - I mean, something which
the compiler can optimize to do the equivalent of accessing the fields directly -
but still keeping the freedom to change things later.

-- 
Martin Baulig
martin gnome org (private)
baulig suse de (work)