Re: patch for bonobo-storage-fs, dangling symlinks

[Dietmar Maurer <dietmar ximian com>]

Vladimir Vukicevic wrote:

> It appears that the fs storage plugin was a bit too fascist when it
> comes to deciding when to abort the operation on a storage.
> Specifically, it would return a NotFound exception if you ever tried
> to listContents() on a directory that had dangling symlinks -- the
> stat() would fail, and it would abort.  It would also abort if it
> couldn't find the file for stat() during listContents, which could
> happen if the file was removed after the call to opendir().
>
> The attached patch fixes both problems; I'm not quite sure that using
> a mime type of "x-symlink/dangling" is ideal for the type but it
> should do for now. :-)
>
> A related issue is that Bonobo/StorageInfo only knows about
> STORAGE_TYPE_REGULAR and STORAGE_TYPE_DIRECTORY files.  It seems that
> it should also have a STORAGE_TYPE_LINK (or _SYMLINK) -- right now,
> the behaviour of the fs storage plugin is that it will give you info
> about the file that's being pointed to, not the link itself.  Changing
> this entails simply using lstat() in the first place instead of
> stat(), but I wanted to get people's input if this makes sense...

I am unsure if we should do that, since the bonobo storage model does not know the concept
of symlinks, i.e. it is also not possible to create a symlink or do something like lstat().
So I think this is nothing we should change now.

- Dietmar