Re: typed BonoboStreams



Hi Dan,

	Having read your patch, I am getting more jumpy about putting
the set_type / get_type methods on the Stream. Currently all the functions
on the stream have no complicated implied ordering. These functions,
particularly 'set' would have to be performed before any read/write/seek
etc.

	Furthermore, I don't think there is a need for a 'get' function,
since in the absence of a 'set' [ which you would do anyway ] the type
used will be the default [ ie. the first item from the get_types ].

	I think then, that perhaps the best way to do this, is all in the
Persist Interface, thus:

		void save (in Bonobo::Stream stream,
		           in Bonobo::StreamType type);

		void load (in Bonobo::Stream stream,
		           in Bonobo::StreamType type) raises (WrongDataType);

	I also tend to think that it is wise to have a typedef for this
string. I don't follow the argument about the 'type' being the type of the
data. The Query function returns a sequence of possible stream types that
can be selected via the set/get type interface. Hence it seems that it
would make it rather clearer in the long term to have this explicitely
typed.

	Comments ?

		Michael.

-- 
 mmeeks@gnu.org  <><, Pseudo Engineer, itinerant idiot





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]