patch to menu_toplevel_set_pixmap



Hi,

    There's a small bug I found in menu_toplevel_set_pixmap_internal
where it forgets to show a newly allocated pixmap widget.  I am
enclosing a small patch to fix this.  Since we need this to work for
Nautilus soon, I will apply the patch to cvs head in 8 hours or so
unless somone objects.

   Please email me directly if you have any issues. Thanks.

-- Andy

Index: bonobo-uih-menu.c
===================================================================
RCS file: /cvs/gnome/bonobo/bonobo/bonobo-uih-menu.c,v
retrieving revision 1.17
diff -u -r1.17 bonobo-uih-menu.c
--- bonobo-uih-menu.c 2000/06/28 15:58:35 1.17
+++ bonobo-uih-menu.c 2000/07/25 00:27:05
@@ -3233,8 +3233,11 @@

  /* Create and insert the new one. */
  pixmap_widget = GTK_WIDGET (bonobo_ui_handler_toplevel_create_pixmap
(menu_widget, type, data));
- gtk_pixmap_menu_item_set_pixmap (GTK_PIXMAP_MENU_ITEM (menu_widget),
+ if (pixmap_widget != NULL) {
+  gtk_widget_show (pixmap_widget);
+  gtk_pixmap_menu_item_set_pixmap (GTK_PIXMAP_MENU_ITEM (menu_widget),
       GTK_WIDGET (pixmap_widget));
+ }
 }

 inline static void







[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]