Re: Inconsistency between libbonobo's PersistFile and PersistStream implementations
- From: Maciej Stachowiak <mjs eazel com>
- To: ERDI Gergo <cactus cactus rulez org>
- Cc: gnome-components-list gnome org
- Subject: Re: Inconsistency between libbonobo's PersistFile and PersistStream implementations
- Date: 31 Dec 2000 15:13:48 -0800
ERDI Gergo <cactus cactus rulez org> writes:
> Hi,
>
> just a minor syntaxic nitpicking: the implementor functions of PersistFile
> have the signature of
> typedef int (*BonoboPersistFileIOFn) (BonoboPersistFile *pf,
> const CORBA_char *filename,
> CORBA_Environment *ev,
> void *closure);
>
> but the functiosn of PersistStream have
>
> typedef void (*BonoboPersistStreamIOFn) (BonoboPersistStream *ps,
> const Bonobo_Stream stream,
> Bonobo_Persist_ContentType type,
> void *closure,
> CORBA_Environment *ev);
>
> Here's a patch to bring consistency (attached). Shall I commit it?
>
I'd appreciate if you don't do this unless you also fix every
component that implements PersistStream (quite a few these days);
though of course the final decision is up to Michael and Miguel.
- Maciej
[
Date Prev][Date Next] [
Thread Prev][Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]