open mode confusion



After trying to add a new open mode (CREATE) I detected that we have
several definitions with unclear semantics:

gnome_storage.h: (Unix like semantics?)

#define GNOME_SS_READ   1
#define GNOME_SS_WRITE  2
#define GNOME_SS_RDWR   3
#define GNOME_SS_CREATE 4
#define GNOME_SS_EXCL   8

gnome_storage.idl: (donīt understand DENY_ modes)

  const OpenMode READ  = 1;
  const OpenMode WRITE = 2;
  const OpenMode DENY_READ = 4;
  const OpenMode DENY_WRITE = 8;

Do we really need these different delcarations? I suggest to use Unix
like modes and define them in gnome-storage.idl:

  const OpenMode RDONLY  = 00;
  const OpenMode WRONLY = 01;
  const OpenMode RDWR = 02;
  const OpenMode CREAT = 0100;
  const OpenMode EXCL = 0200;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]