Re: [Evolution-hackers] Patch Review process

[Olav Vitters <olav bkor dhs org>]

On Mon, May 09, 2005 at 09:50:33AM -0600, Elijah Newren wrote:
> On 5/9/05, JP Rosevear <jpr novell com> wrote:
> > On Mon, 2005-05-09 at 20:05 +0530, Harish Krishnaswamy wrote:
> > > During the irc meeting last week,  we discussed the pros and cons of
> > > deprecating evolution-patches and using bugzilla as the treasure
> > > bag for patches.
[..]
> > > Fresh thoughts, any ?
> > 
> > Yes.  The ideal way might be to use bugzilla for patches and see if we
> > could get automated mails to e-p containing the bug number, product,
> > component and summary (and a link) if a patch is attachment is set on a
> > bug.
> 
> Sounds somewhat similar to the automated patch-nagging we were
> planning on doing (though that was more aimed at patches that had been
> in bugzilla for a long time without being reviewed, but I'm sure the
> same code could be used to do something like this).  I think this
> sounds reasonable.

A totally custom message for patches is not that easy (unfortunately).
But the bugmail about the attachment contains everything that is
needed. It has product/component/version in the body of the mail,
summary of the patch + additional comment if provided.

Two suggestions:
1. Add evolution-patches as a user to bugzilla.gnome.org. Let that watch
evolution-qa ximian com and whatever other products are needed. For
evolution-patches every email option should be disabled except 'New
Attachments are added'.

2. Do same as above, but hack (it will be a hack) processmail so that
'New Attachments' for the evolution-patches means attachment has 'patch'
flag set. (non-patches are not mailed)

-- 
Regards,
Olav